Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Edge <=18 support from package.json for 21.04 #2691

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Drop Edge <=18 support from package.json for 21.04 #2691

merged 2 commits into from
Jan 28, 2021

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Jan 28, 2021 •
edited
Loading

What:

Why:

How:

Checklist:

@saberlynx saberlynx changed the title Drop Edge <=18 support from package.json Drop Edge <=18 support from package.json for 21.04 Jan 28, 2021
@saberlynx saberlynx marked this pull request as ready for review January 28, 2021 14:10
@saberlynx saberlynx requested a review from a team January 28, 2021 14:11
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #2691 (0a0f969) into gsa-21.04 (34466a4) will increase coverage by 0.15%.
The diff coverage is 94.11%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.04    #2691      +/-   ##
=============================================
+ Coverage      53.71%   53.86%   +0.15%     
=============================================
  Files           1072     1073       +1     
  Lines          26223    26228       +5     
  Branches        7474     7468       -6     
=============================================
+ Hits           14086    14129      +43     
+ Misses         11019    10983      -36     
+ Partials        1118     1116       -2
Impacted Files Coverage Δ
gsa/src/gmp/capabilities/capabilities.js 100.00% <ø> (ø)
gsa/src/gmp/commands/policies.js 86.15% <ø> (ø)
gsa/src/gmp/commands/roles.js 33.33% <ø> (ø)
gsa/src/gmp/commands/scanconfigs.js 90.62% <ø> (ø)
gsa/src/gmp/gmp.js 80.00% <ø> (ø)
gsa/src/gmp/http/utils.js 33.33% <ø> (ø)
gsa/src/gmp/locale/lang.js 95.12% <ø> (ø)
gsa/src/gmp/locale/languages.js 100.00% <ø> (ø)
gsa/src/gmp/log.js 100.00% <ø> (ø)
gsa/src/gmp/model.js 100.00% <ø> (ø)
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e505ce...0a0f969. Read the comment docs.

@bjoernricks bjoernricks merged commit 04aa55b into greenbone:gsa-21.04 Jan 28, 2021
@bjoernricks
Copy link
Contributor

This PR needs a merge into master too I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@sarahd93 sarahd93 Awaiting requested review from sarahd93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saberlynx @bjoernricks @swaterkamp